fix: Truncate query in exceptions and add test coverage for protocol limits#15
Merged
mkaufmann merged 4 commits intoforcedotcom:mainfrom Feb 14, 2025
Merged
Conversation
…limits With this change we are checking limits around: - headers - request size - parameter sizes The driver already passed all limits but the tests uncoverd a significant inefficiency around exception creation. With multi megabyte queries this was causing multi second hangs. Thus we now truncate the query in the exception message.
mkaufmann
force-pushed
the
mkaufmann-test-limits
branch
from
794dbf1 to
e80b0a9
Compare
src/main/java/com/salesforce/datacloud/jdbc/exception/QueryExceptionHandler.java
Outdated
Show resolved
Hide resolved
KaviarasuSakthivadivel
previously approved these changes
Feb 13, 2025
KaviarasuSakthivadivel
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change we are checking limits around:
The driver already passed all limits but the tests uncoverd a significant inefficiency around exception creation. With multi megabyte queries this was causing multi second hangs. Thus we now truncate the query in the exception message.
If the query is truncated it'll have a
<truncated>suffix